aland/quickshell
1
0
Fork 0
mirror of https://git.outfoxxed.me/quickshell/quickshell.git synced 2026-04-10 06:11:54 +10:00
Code Issues Projects Releases Packages Wiki Activity Actions

core/log: crash if Quickshell's log filter is installed twice

Browse source 
Crashes from recursion inside filterCategories through the old filter
have been observed. Presumably this means the log filter is getting
installed twice somehow. This should catch it.
This commit is contained in:
outfoxxed 2026-04-06 00:45:26 -07:00
parent 5bf6a412b0
commit 7c5a6c4bd4
No known key found for this signature in database
GPG key ID: 4C88A185FB89301E
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/core/logging.cpp
View file

@ -310,10 +310,15 @@ void LogManager::init(
instance->rules->append(parser.rules()); instance->rules->append(parser.rules());
} }
qInstallMessageHandler(&LogManager::messageHandler);
instance->lastCategoryFilter = QLoggingCategory::installFilter(&LogManager::filterCategory); instance->lastCategoryFilter = QLoggingCategory::installFilter(&LogManager::filterCategory);
if (instance->lastCategoryFilter == &LogManager::filterCategory) {
qCFatal(logLogging) << "Quickshell's log filter has been installed twice. This is a bug.";
instance->lastCategoryFilter = nullptr;
}
qInstallMessageHandler(&LogManager::messageHandler);
qCDebug(logLogging) << "Creating offthread logger..."; qCDebug(logLogging) << "Creating offthread logger...";
auto* thread = new QThread(); auto* thread = new QThread();
instance->threadProxy.moveToThread(thread); instance->threadProxy.moveToThread(thread);