aland/quickshell
1
0
Fork 0
mirror of https://git.outfoxxed.me/quickshell/quickshell.git synced 2025-11-04 19:04:56 +11:00
Code Issues Projects Releases Packages Wiki Activity Actions

services/pipewire: destroy qml ifaces early to avoid user callbacks

Browse source 
Consumers of defaultAudio*Changed signals can run code between
safeDestroy being called and PwObjectIface destruction due to
signal connection order. This change destroys ifaces earlier so they
are nulled by the time a changed signal is fired from destruction,
preventing access between ~PwNode() and ~QObject() completion.

Fixes #116 #122 #124
This commit is contained in:
outfoxxed 2025-07-17 00:06:32 -07:00
parent 201c559dcd
commit 91dcb41d22
No known key found for this signature in database
GPG key ID: 4C88A185FB89301E
2 changed files with 14 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/services/pipewire/qml.cpp
View file

@ -18,6 +18,16 @@
namespace qs::service::pipewire {
PwObjectIface::PwObjectIface(PwBindableObject* object): QObject(object), object(object) {
// We want to destroy the interface before QObject::destroyed is fired, as handlers
// connected before PwObjectIface will run first and emit signals that hit user code,
// which can then try to reference the iface again after ~PwNode() has been called but
// before ~QObject() has finished.
QObject::connect(object, &PwBindableObject::destroying, this, &PwObjectIface::onObjectDestroying);
}
void PwObjectIface::onObjectDestroying() { delete this; }
void PwObjectIface::ref() {
this->refcount++;